Validate FFI primitive inputs + refresh bindings/tests#1263
Open
chavic wants to merge 3 commits intopayjoin:masterfrom
Open
Validate FFI primitive inputs + refresh bindings/tests#1263chavic wants to merge 3 commits intopayjoin:masterfrom
chavic wants to merge 3 commits intopayjoin:masterfrom
Conversation
Collaborator
Pull Request Test Coverage Report for Build 21681318162Details
💛 - Coveralls |
chavic
force-pushed
the
chavic/primitives-validation
branch
2 times, most recently
from
cd3391a to
a44a282
Compare
chavic
force-pushed
the
chavic/primitives-validation
branch
2 times, most recently
from
59affc6 to
93bc4e8
Compare
chavic
force-pushed
the
chavic/primitives-validation
branch
5 times, most recently
from
055a2bb to
53db1cb
Compare
chavic
requested review from
DanGould,
arminsabouri,
benalleng and
spacebear21
benalleng
requested changes
Feb 4, 2026
Collaborator
Author
Thanks... applying that now |
chavic
force-pushed
the
chavic/primitives-validation
branch
from
759be1b to
10ee724
Compare
chavic
force-pushed
the
chavic/primitives-validation
branch
3 times, most recently
from
edad0fc to
a1711eb
Compare
chavic
force-pushed
the
chavic/primitives-validation
branch
4 times, most recently
from
84e2546 to
732c40a
Compare
chavic
force-pushed
the
chavic/primitives-validation
branch
from
732c40a to
f331ef3
Compare
benalleng
approved these changes
Feb 9, 2026
| ).build().save(recvPersister).pjUri(); | ||
|
|
||
| final psbt = | ||
| "cHNidP8BAHMCAAAAAY8nutGgJdyYGXWiBEb45Hoe9lWGbkxh/6bNiOJdCDuDAAAAAAD+////AtyVuAUAAAAAF6kUHehJ8GnSdBUOOv6ujXLrWmsJRDCHgIQeAAAAAAAXqRR3QJbbz0hnQ8IvQ0fptGn+votneofTAAAAAAEBIKgb1wUAAAAAF6kU3k4ekGHKWRNbA1rV5tR5kEVDVNCHAQcXFgAUx4pFclNVgo1WWAdN1SYNX8tphTABCGsCRzBEAiB8Q+A6dep+Rz92vhy26lT0AjZn4PRLi8Bf9qoB/CMk0wIgP/Rj2PWZ3gEjUkTlhDRNAQ0gXwTO7t9n+V14pZ6oljUBIQMVmsAaoNWHVMS02LfTSe0e388LNitPa1UQZyOihY+FFgABABYAFEb2Giu6c4KO5YW0pfw3lGp9jMUUAAA="; |
Collaborator
There was a problem hiding this comment.
You should have access to this from test_utils. I think I'd like to see this properly imported here.
| "bitcoin:12c6DSiU4Rq3P4ZxziKxzrL5LmMBrzjrJX?amount=1&pj=https://example.com", | ||
| ).checkPjSupported(); | ||
| const psbt = | ||
| "cHNidP8BAHMCAAAAAY8nutGgJdyYGXWiBEb45Hoe9lWGbkxh/6bNiOJdCDuDAAAAAAD+////AtyVuAUAAAAAF6kUHehJ8GnSdBUOOv6ujXLrWmsJRDCHgIQeAAAAAAAXqRR3QJbbz0hnQ8IvQ0fptGn+votneofTAAAAAAEBIKgb1wUAAAAAF6kU3k4ekGHKWRNbA1rV5tR5kEVDVNCHAQcXFgAUx4pFclNVgo1WWAdN1SYNX8tphTABCGsCRzBEAiB8Q+A6dep+Rz92vhy26lT0AjZn4PRLi8Bf9qoB/CMk0wIgP/Rj2PWZ3gEjUkTlhDRNAQ0gXwTO7t9n+V14pZ6oljUBIQMVmsAaoNWHVMS02LfTSe0e388LNitPa1UQZyOihY+FFgABABYAFEb2Giu6c4KO5YW0pfw3lGp9jMUUAAA="; |
Collaborator
There was a problem hiding this comment.
Same here for the test_utils import. though we would have to add it to the test_utils/index.js it seems
Collaborator
There was a problem hiding this comment.
The unit tests seem to have inconsistent tests. Is there a specific reason that this is the case? The python unit tests here seem to be the most complete
Collaborator
There was a problem hiding this comment.
A question for a followup perhaps but should we consider making a primitives module to keep this kind of file in case we end up needing more like it?
benalleng
requested changes
Feb 9, 2026
benalleng
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #1262 and hardens the FFI boundary by validating primitive inputs and surfacing explicit errors. Updates integration tests/bindings to match the new error shapes and removes silent acceptance of invalid fee rates/amounts.
Follow-ups
Decide final script/witness size caps and document rationale.
Add Dart integration fix for large fee rate parsing (separate PR).