-
Notifications
You must be signed in to change notification settings - Fork 79
[Migrated from ohttp-relay] - Dockerfile ohttp relay #1244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Pull Request Test Coverage Report for Build 20395401893Details
💛 - Coveralls |
| RUN nix \ | ||
| --extra-experimental-features "nix-command flakes" \ | ||
| --option filter-syscalls false \ | ||
| build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't think this will work, COPY . /tmp/build will only copy the ohttp-relay subdirectory. if the root was copied, there's no default package defined, so at the very least we need to build like this:
| build .#ohttp-relay |
if we take the Dockerfile route, but i think it's much easier to use https://github.com/nlewo/nix2container which has the same effect as this dockerfile except the image is constructed directly from a nix derivation, and you can just nix build .#ohttp-relay.dockerImage
regardless, mainly in order to note this down somewhere linked, this will currently ship a release binary but if #1228 is merged it will start shipping debug builds
Originally opened in payjoin/ohttp-relay#49
Feel free to take or leave anything you like here, but wanted to push upstream some minor optimizations to the Dockerfile along with an easy way to get automatic Docker image builds via Github Actions, for both amd64 and arm64.
The main part you may not want is pinning Docker images to releases/tags as I've done here, if not I'm happy to modify the PR to remove that aspect, but I personally like that for two reasons:
More detailed discussion is listed in the original repo.
v0.0.9
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.