Remove redis from directory docker-compose#1095
Draft
spacebear21 wants to merge 1 commit intopayjoin:masterfrom
Draft
Remove redis from directory docker-compose#1095spacebear21 wants to merge 1 commit intopayjoin:masterfrom
spacebear21 wants to merge 1 commit intopayjoin:masterfrom
Conversation
Redis is no longer needed to run the directory service.
Collaborator
Author
|
Converting to Draft because I'm not sure whether PJ_STORAGE_DIR needs to be set explicitly? cc @nothingmuch |
Collaborator
Pull Request Test Coverage Report for Build 17867660605Details
💛 - Coveralls |
Collaborator
|
it does, i didn't set a default value because the one for ohttp-keys seemed a bit cavalier just going with something in the current directory we could figure out if we want to use xdg directories (not sure that's advised for a service) or maybe |
Collaborator
Author
|
This change also requires an up-to-date docker image for |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redis is no longer needed to run the directory service.
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.