⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Conversation

@drgrice1
Copy link
Member

@drgrice1 drgrice1 commented Feb 1, 2026

The default option should be disabled.

The default option should be disabled.
@somiaj
Copy link
Contributor

somiaj commented Feb 1, 2026

Straight forward single edit fix, I am just going to merge.

@somiaj somiaj merged commit 0ff2b86 into openwebwork:develop Feb 1, 2026
2 checks passed
@somiaj
Copy link
Contributor

somiaj commented Feb 1, 2026

@drgrice1 One other thing I notice (not part of this PR change), if I hit the checkbox to select all sets, then hit edit, when the edit page loads the select all checkbox is initially selected and then after the javascript finishes loading, it is then unslected, causing a visual change. So everything works just fine, just a small visual flash that caught my eye.

@drgrice1
Copy link
Member Author

drgrice1 commented Feb 1, 2026

Note that only happens if you enter the edit page by editing "selected sets". It doesn't if you edit "all course sets". The reason for it is that you had the checkbox by the same name on the set list page checked. So the Mojolicious auto form filling handling automatically checks it again. But then the selectall.js code sees that none of the check boxes in the select all's group are checked and unchecks it.

This is a rather minor visual change that most won't notice, and I don't care if a few that are more observant do. It isn't worth trying to fix.

@somiaj
Copy link
Contributor

somiaj commented Feb 1, 2026

Yea, I only noticed it when using the select all feature, and it is minor visual issue, everything works fine, I just thought I would mention it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants