Insulation score should weight by # of NaNs in each diagonal#459
Open
gdolsten wants to merge 1 commit intoopen2c:masterfrom
Open
Insulation score should weight by # of NaNs in each diagonal#459gdolsten wants to merge 1 commit intoopen2c:masterfrom
gdolsten wants to merge 1 commit intoopen2c:masterfrom
Conversation
I had trouble fully understanding the insul_diamond function but I thought we could add something like this so that insulation score at regions with NaN covering some of the diamond are not punished
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had trouble fully understanding the insul_diamond function but I thought we could add something like this so that insulation score at regions with NaN covering some of the diamond are not punished