updated npm deps and added optional arguments for captured image dimensions#18
Open
capaj wants to merge 5 commits intoonemightyroar:masterfrom
Open
updated npm deps and added optional arguments for captured image dimensions#18capaj wants to merge 5 commits intoonemightyroar:masterfrom
capaj wants to merge 5 commits intoonemightyroar:masterfrom
Conversation
… capture dimensions, bumped versions
Author
There was a problem hiding this comment.
I wanted to do more changes, but I did not in the end.
I needed to increment multiple times as I was in a hurry(hacktahon).
Feel free to merge this as 0.1.4
Member
|
All in all, this cleans up a bunch of stuff. My only question is the bump in version. Once that's resolve this should be good to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.