Added a user_id parameter in user_info/read API response#901
Open
kapeels wants to merge 1 commit intoohmage:masterfrom
Open
Added a user_id parameter in user_info/read API response#901kapeels wants to merge 1 commit intoohmage:masterfrom
kapeels wants to merge 1 commit intoohmage:masterfrom
Conversation
Member
Author
|
@stevenolen Would love your thoughts on this. This is all experimental! |
stevenolen
reviewed
May 18, 2017
Member
stevenolen
left a comment
There was a problem hiding this comment.
finally had a chance to take a look! this is a pretty slick way of accomplishing the task you're looking to do.
I'd suggest implementing one extra layer on top of this -- a config param that is disabled by default to return the extra field only if true, mainly since you're returning an existing user value and it can't be known definitively how others are using said value. maybe something like return_user_id=true?
Happy to see a more stable workaround!
Member
Author
|
The config param's a great idea - it'd keep any clients from breaking. Thanks, Steve! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to allow client applications to have a numeric id associated with a user account.
To be used by the pam_ohmage module. This is one of the solutions to pam_ohmage #3.
However, I am not sure if ohmage should be doing this. I cannot see how this change would break anything within ohmage or any of the existing client application.
Is there a reason ohmage did not return the numeric user ids?