-
Notifications
You must be signed in to change notification settings - Fork 2k
docs: Add note about the bot opening PRs #2339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
8a64419 to
b1b0cac
Compare
|
The link failure seems unrelated, and appears to still be rendering on the README |
|
@nschonni - brian from the website team here, I have had a TODO to document this process for a while. If I draft it up will you take a look? This seems like a great thing to make more clear, especially when security create urgency WIP below
|
|
Sure, feel free to suggest or push changes to this branch. This was just a quick idea so people wouldn't open PRs that we wouldn't land, but it could use finesse. |
|
@nschonni sorry for the double ping - I was editing as I worked to understand it myself. please take a look at my initial comment 😄 and thanks! |
|
That's probably useful info that could be either in this doc or the README. I think it probably needs to be clear in a few places. I think some of the mermaid diagrams have been used in the other repos too |
techgaun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok awesome thank you. Waiting for this.
Might want something that points to the next steps on the docker side. The automation links to that after the PR lands https://github.com/nodejs/docker-node/blob/main/.github%2Fworkflows%2Fofficial-pr.yml#L66 |
SimenB
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense 👍
Description
Makes a note about how the Bot will open PRs, but we do appreciate PRs when new major versions are released.
Motivation and Context
Testing Details
Example Output(if appropriate)
Types of changes
Checklist