⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Conversation

@nschonni
Copy link
Member

Description

Makes a note about how the Bot will open PRs, but we do appreciate PRs when new major versions are released.

Motivation and Context

Testing Details

Example Output(if appropriate)

Types of changes

  • Documentation
  • Version change (Update, remove or add more Node.js versions)
  • Variant change (Update, remove or add more variants, or versions of variants)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (none of the above)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • All new and existing tests passed.

@nschonni nschonni marked this pull request as draft January 13, 2026 21:10
@nschonni nschonni force-pushed the nschonni-contributing-tweak branch from 8a64419 to b1b0cac Compare January 13, 2026 21:12
@nschonni nschonni changed the title docs: Add not about the bot opening PRs docs: Add note about the bot opening PRs Jan 13, 2026
@nschonni nschonni marked this pull request as ready for review January 13, 2026 21:15
@nschonni nschonni enabled auto-merge January 13, 2026 21:15
@nschonni nschonni disabled auto-merge January 13, 2026 21:15
@nschonni nschonni requested a review from a team January 13, 2026 21:15
@nschonni
Copy link
Member Author

The link failure seems unrelated, and appears to still be rendering on the README

@bmuenzenmeyer
Copy link

bmuenzenmeyer commented Jan 14, 2026

@nschonni - brian from the website team here, I have had a TODO to document this process for a while. If I draft it up will you take a look? This seems like a great thing to make more clear, especially when security create urgency

WIP below

@nschonni
Copy link
Member Author

Sure, feel free to suggest or push changes to this branch. This was just a quick idea so people wouldn't open PRs that we wouldn't land, but it could use finesse.

@bmuenzenmeyer
Copy link

@nschonni sorry for the double ping - I was editing as I worked to understand it myself. please take a look at my initial comment 😄

and thanks!

@nschonni
Copy link
Member Author

That's probably useful info that could be either in this doc or the README. I think it probably needs to be clear in a few places. I think some of the mermaid diagrams have been used in the other repos too

Copy link

@techgaun techgaun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok awesome thank you. Waiting for this.

@nschonni
Copy link
Member Author

@nschonni - brian from the website team here, I have had a TODO to document this process for a while. If I draft it up will you take a look? This seems like a great thing to make more clear, especially when security create urgency

WIP below

Might want something that points to the next steps on the docker side. The automation links to that after the PR lands https://github.com/nodejs/docker-node/blob/main/.github%2Fworkflows%2Fofficial-pr.yml#L66

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense 👍

@bmuenzenmeyer bmuenzenmeyer mentioned this pull request Jan 14, 2026
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants