Open
Conversation
UlisesGascon
approved these changes
Apr 5, 2024
Member
UlisesGascon
left a comment
There was a problem hiding this comment.
Thanks for adding Astro ❤️
Member
Author
|
Before merging I wanna make sure it's not flaky and everything working correctly |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1055 +/- ##
=======================================
Coverage 96.35% 96.35%
=======================================
Files 29 29
Lines 2192 2192
=======================================
Hits 2112 2112
Misses 80 80 ☔ View full report in Codecov by Sentry. |
Update lookup.json
bjohansebas
approved these changes
Feb 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpasseshere
Ref: #1054
Hard Requirements
npm install && npm testor (yarn install && yarn testor
pnpm install && pnpm test) using the tarballdownloaded from the Github tag mentioned above - don't think it's relevant anymore as you have
scriptsSoft Requirements
At least one of:
OR - Yes, this is the first big project that uses
node:testRun this branch on CITGM to make sure I'm not introducing flaky tests:
TODO