-
Notifications
You must be signed in to change notification settings - Fork 19
add a pip install and lint to the PR build to validate install time deps without the lock #182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for contributing! 👋 |
irwand
approved these changes
May 17, 2024
d03dd4e to
ffaeddd
Compare
Collaborator
Author
|
@irwand, I'm not sure why I never completed this PR...., but with the recent changes to the PR template, I've basically rewritten it. |
irwand
approved these changes
Dec 9, 2025
9c03b94 to
a69e110
Compare
bkeryan
reviewed
Dec 9, 2025
bkeryan
reviewed
Dec 9, 2025
mshafer-NI
commented
Dec 9, 2025
mshafer-NI
commented
Dec 9, 2025
…eps without the lock
… like current latest
a8098d2 to
d608e06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that we are broken at install time.
I would like a PR check to alert us to this on the lock PRs.