-
Notifications
You must be signed in to change notification settings - Fork 134
NLB-2234: update vmss backend documentation #1642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview will be available once build job completes!
|
arussellf5
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is excellent documentation! Thank you
|
|
||
| ## Getting Started | ||
|
|
||
| ### Step 1: Create NGINXaaS deployment with dynamic upstreams |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ### Step 1: Create NGINXaaS deployment with dynamic upstreams | |
| ### Create NGINXaaS deployment with dynamic upstreams |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make this at other places as well.
Refer: #1384
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated above suggested changes
|
|
||
| ## Overview | ||
|
|
||
| The NGINXaaS dataplane API key is used to authenticate with your NGINXaaS deployment's dataplane API. This key is required for various integrations including VMSS backend synchronization and Kubernetes load balancing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Arent these both load balancing (VMSS and Kubernetes)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it is useful both. Thats the reason i created a separate common page and use this reference in both VMSS and kubernetes places
|
|
||
| ## Create the API Key | ||
|
|
||
| The data plane API key can be created using the Azure CLI or portal. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any link needed here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think mostly not needed because we are mentioning the both procedures below. If you think if some links would be helpful, then definitely I can include them.
|
|
||
| ```bash | ||
| # Set role name | ||
| roleName="VMSS-Network-Read-Role" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why set this here? It's not used until later (the Assign the Custom Role script).
| ```yaml | ||
| # nginx-asg-sync configuration for NGINXaaS for Azure | ||
| cloud_provider: Azure | ||
| subscription_id: your_subscription_id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the json file mentioned above, you used "<SUBSCRIPTION_ID>" nomenclature to indicate items that the user needed to substitute real values into. Should we use the same pattern here?
|
|
||
| ``` | ||
| 2026/01/08 15:44:12 nginx-asg-sync version 1.0.3 | ||
| 2026/01/08 15:44:13 Updated HTTP servers of backend-one for group naveen-vmss-latest ; Added: [172.19.0.6:80 172.19.0.7:80], Removed: [], Updated: [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably don't want your name in here (and below)
|
|
||
| You can assign managed identity permissions using: | ||
|
|
||
| - **Azure Portal**: Navigate to **Resource** → **Identity** → **Role assignments** in the Azure portal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wasn't clear what the starting point for this was? Which resource should I be looking at in the Portal?
Proposed changes
Checklist
Before sharing this pull request, I completed the following checklist:
Footnotes
Potentially sensitive information includes personally identify information (PII), authentication credentials, and live URLs. Refer to the style guide for guidance about placeholder content. ↩