reply to a thread should navigate to a thread #5836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sowjanyakch
requested review from
mahibi and
rapterjet2004
and removed request for
mahibi
Signed-off-by: sowjanyakch <[email protected]>
sowjanyakch
force-pushed
the
fix/5832/threadReply
branch
from
c0bdbbb to
6a084aa
Compare
Contributor
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5836.apk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #5832
There should be no option to quote a thread. Reply to a thread should navigate to the thread (same behavior is seen in ioS and web).
Had to fix this because it impacts scheduled message. Quote to a thread should not be scheduled or sent (both cases will cause unnecessary network call to schedule endpoint or send endpoint).
🚧 TODO
🏁 Checklist
/backport to stable-xx.x