⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Optimize banning item layout#5828

Merged
AndyScherzinger merged 1 commit intomasterfrom
style/noid/banningItemLayout
Feb 10, 2026
Merged

Optimize banning item layout#5828
AndyScherzinger merged 1 commit intomasterfrom
style/noid/banningItemLayout

Conversation

@AndyScherzinger
Copy link
Member

  • use typical 2 line item coloring and text sized
  • move padding to the item not the list

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@AndyScherzinger AndyScherzinger added this to the 23.1.0 milestone Feb 9, 2026
@AndyScherzinger AndyScherzinger added design Related to the design 3. to review Waiting for reviews labels Feb 9, 2026
@AndyScherzinger
Copy link
Member Author

/backport to stable-23.0

@mahibi mahibi force-pushed the style/noid/banningItemLayout branch from 8aa8f09 to 190c394 Compare February 10, 2026 09:59
@AndyScherzinger AndyScherzinger force-pushed the style/noid/banningItemLayout branch from 190c394 to abbb3c2 Compare February 10, 2026 13:20
@github-actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5828.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings9898
Errors00

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1010
Dodgy code5454
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total8181

@AndyScherzinger AndyScherzinger merged commit 3002a16 into master Feb 10, 2026
17 of 21 checks passed
@AndyScherzinger AndyScherzinger deleted the style/noid/banningItemLayout branch February 10, 2026 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews design Related to the design

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants