feat(permissions): Add support for separate REACT permission #5754
Conversation
AndyScherzinger
added
enhancement
luflow
force-pushed
the
feature/split-chat-and-reaction-permission
branch
from
373af2f to
294c178
Compare
|
@AndyScherzinger just updated this branch based on feedback in spreed-PR - also wrote a small migration guide that covers all changes to be more understandable :) https://github.com/luflow/spreed/blob/93bedef92873edbf7a4ae28730c0d514a1cd2f97/docs/react-permission-integration.md |
|
thank you @luflow , great idea 👍 |
|
i will come back to this when the server PR is merged ;) |
luflow
force-pushed
the
feature/split-chat-and-reaction-permission
branch
2 times, most recently
from
612e90a to
18629f7
Compare
Adds compatibility with nextcloud/spreed#16835 which splits the combined CHAT permission into separate CHAT (128) and REACT (256) permissions. This enables "announcement channels" where only moderators can post messages, but all users can still react. Changes: - Add REACT (256) permission constant to ParticipantPermissions - Add hasReactPermission() method with backward compatibility fallback - Update MessageActionsDialog to use react permission for emoji bar - Add permission check in onClickReaction() for toggling reactions - Add unit tests for new permission handling Signed-off-by: Florian Ludwig <[email protected]>
- Add REACT_PERMISSION feature to SpreedFeatures enum - Update hasReactPermission() to check react-permission capability first - Fall back to chat-permission/CHAT bit for older servers - Expand unit tests for all capability scenarios Signed-off-by: Florian Ludwig <[email protected]>
…sponding error message Signed-off-by: Florian Ludwig <[email protected]>
Signed-off-by: Florian Ludwig <[email protected]>
Servers that support react-permission also support chat-permission since it is an older capability. Update test setup to reflect this realistic server configuration. Signed-off-by: Florian Ludwig <[email protected]>
luflow
force-pushed
the
feature/split-chat-and-reaction-permission
branch
from
4661e53 to
51567c6
Compare
|
just a reminder to myself: if users complain that nothing happens when they try to react, ask them to update the app (this PR needs to be included in the release of course) |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
3 participants
Adds compatibility with nextcloud/spreed#16835 which splits the combined CHAT permission into separate CHAT (128) and REACT (256) permissions.
This enables "announcement channels" where only moderators can post messages, but all users can still react.
Changes:
🏁 Checklist
/backport to stable-xx.x