fix: use stable route for comment search results#54379
Draft
fix: use stable route for comment search results#54379
Conversation
8 tasks
The old version with files.view.index (with dir and scrollto) is opening the folder, but does not open the file or scroll to it. The recommended way to reference a file is files.view.showFile as done by the files search provider and the activites app. OCA\Comments\Search\LegacyProvider and OCA\Comments\Search\Result are deprecated since 20 and thus I took the opportunity to migrate away from it. Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
76d0044 to
756bdef
Compare
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The old version with files.view.index (with dir and scrollto) is opening the folder, but does not open the file or scroll to it.
The recommended way to reference a file is files.view.showFile as done by the files search provider and the activites app.
OCA\Comments\Search\LegacyProvider and OCA\Comments\Search\Result are deprecated since 20 and thus I took the opportunity to migrate away from it.
TODO
Checklist