Open
Conversation
maltelenz
reviewed
Oct 14, 2025
Contributor
maltelenz
left a comment
maltelenz
left a comment
There was a problem hiding this comment.
Seems fine to me. I added some minor language suggestions.
Co-authored-by: Malte Lenz <[email protected]>
maltelenz
approved these changes
Oct 14, 2025
Contributor
maltelenz
left a comment
maltelenz
left a comment
There was a problem hiding this comment.
I guess we should have consensus before merging, but it seems fine to me.
beutlich
reviewed
Oct 14, 2025
| <li>Any new parameter must have a default value.</li> | ||
| <li>Any new function input must be after existing inputs and have a default value.</li> | ||
| <li>Any new function output must be after existing outputs.</li> | ||
| </ul> |
Member
There was a problem hiding this comment.
Something like is missing: Any new enumeration alternative must be after existing alternatives.
Contributor
Author
There was a problem hiding this comment.
True, and that made me realize that the same was true for records, and that both of them also imposed requirements on user models.
Co-authored-by: Thomas Beutlich <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #4694 (the feedback from the MAP-Lib meeting was to make it a PR).
Basically:
I added a import-restriction for usage compared to issue, I hope I didn't miss anything else.