⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Conversation

@zcbenz
Copy link
Collaborator

@zcbenz zcbenz commented Jan 18, 2026

There is a pitfall in GitHub Actions that the default value of workflow_dispatch inputs can only be string, so when setting default: true we might get a string "true" or a boolean false as default value (it seems that we ran into the latter case).

This PR just removes the default values so inputs would all default to boolean false for pushes.

Also note that I'm using a non-exist env in name: ${{ inputs.dry_run && 'dry-run' || 'pypi' }} because inputs.dry_run && '' || 'pypi' would always evaluate to pypi regardless of the input value, which is another pitfall.

Checked a few cases and they all seem to work as expected:

- uses: ./.github/actions/build-docs

deploy_documentation:
if: ${{ github.event_name == 'push' || inputs.publish }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about removing that: github.event_name == 'push'

I added it because these steps weren't getting triggered because the inputs were not defined when it's a push (vs when it's a manual trigger).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's not defined will !inputs.dry_run evaluate to true?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants