Do not give workflow boolean inputs default values #3014
+13
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a pitfall in GitHub Actions that the default value of workflow_dispatch inputs can only be string, so when setting
default: truewe might get a string "true" or a boolean false as default value (it seems that we ran into the latter case).This PR just removes the default values so inputs would all default to boolean
falsefor pushes.Also note that I'm using a non-exist env in
name: ${{ inputs.dry_run && 'dry-run' || 'pypi' }}becauseinputs.dry_run && '' || 'pypi'would always evaluate topypiregardless of the input value, which is another pitfall.Checked a few cases and they all seem to work as expected: