-
Notifications
You must be signed in to change notification settings - Fork 5
Upgrade kcs/class-finder and more! #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR upgrades the kcs/class-finder dependency from version ^0.3 to ^0.6 and addresses associated breaking changes. It also removes deprecated RequestModifier functionality that became obsolete after CakePHP 5 removed the RequestHandlerComponent, locks linter versions to prevent breaking changes, and improves CI pipeline version testing.
- Upgrades
kcs/class-finderfrom ^0.3 to ^0.6 and adapts to its breaking changes - Removes
RequestModifierclass and associated tests (no longer needed in CakePHP 5) - Locks dev dependency versions and updates CI to test with PHP 8.4
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| composer.json | Updates kcs/class-finder to ^0.6 and locks linter versions to specific minor versions |
| src/Utility/NamespaceUtility.php | Adds useAutoloading(false) to handle breaking changes in class-finder library |
| src/Response/ResponseModifier.php | Removes deprecated ResponseModifier class |
| tests/TestCase/Response/ResponseModifierTest.php | Removes test file for deleted ResponseModifier class |
| src/Model/ModelPropertyFactory.php | Adds trailing comma to constructor parameters |
| src/Model/ModelFactory.php | Adds trailing comma to constructor parameters |
| src/Model/Model.php | Adds trailing comma to constructor parameters |
| tests/bootstrap.php | Removes unused constant definitions |
| phpcs.xml | Removes deprecated installed_paths configuration |
| .github/workflows/pull-request.yml | Updates PHP version to 8.4 and improves version testing strategy |
| .github/workflows/master.yml | Updates PHP version to 8.4 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| run: | | ||
| composer self-update | ||
| rm -rf composer.lock | ||
| composer install --prefer-dist --no-interaction --no-progress |
Copilot
AI
Oct 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sequence of commands is inefficient: composer install is immediately followed by composer update, making the install step redundant. Since composer.lock is removed, running composer update alone would be sufficient. Consider removing line 29 to avoid unnecessary work.
| composer install --prefer-dist --no-interaction --no-progress |
RequestModifierwhich is no longer needed since theRequestHandlerComponentwas removed by CakePHP in version 5.