⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Conversation

@cnizzardini
Copy link
Member

@cnizzardini cnizzardini commented Oct 22, 2025

  • Updates alekitto/class-finder from ^0.3 to ^0.6 and resolves breaking changes in that library a long the way. This resolves PHP 8.4 deprecations being emitted by a class-finder dependency: thecodingmachine/safe.
  • Handle some breaking changes in linters and lock linter versions
  • Improve upper and lower bound version check in CI pipeline.
  • Remove RequestModifier which is no longer needed since the RequestHandlerComponent was removed by CakePHP in version 5.

@cnizzardini cnizzardini changed the title Update dependency to deal with deprecations in depedency tree Upgrade kcs/class-finder and more! Oct 22, 2025
@cnizzardini cnizzardini requested a review from Copilot October 22, 2025 13:03
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the kcs/class-finder dependency from version ^0.3 to ^0.6 and addresses associated breaking changes. It also removes deprecated RequestModifier functionality that became obsolete after CakePHP 5 removed the RequestHandlerComponent, locks linter versions to prevent breaking changes, and improves CI pipeline version testing.

  • Upgrades kcs/class-finder from ^0.3 to ^0.6 and adapts to its breaking changes
  • Removes RequestModifier class and associated tests (no longer needed in CakePHP 5)
  • Locks dev dependency versions and updates CI to test with PHP 8.4

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
composer.json Updates kcs/class-finder to ^0.6 and locks linter versions to specific minor versions
src/Utility/NamespaceUtility.php Adds useAutoloading(false) to handle breaking changes in class-finder library
src/Response/ResponseModifier.php Removes deprecated ResponseModifier class
tests/TestCase/Response/ResponseModifierTest.php Removes test file for deleted ResponseModifier class
src/Model/ModelPropertyFactory.php Adds trailing comma to constructor parameters
src/Model/ModelFactory.php Adds trailing comma to constructor parameters
src/Model/Model.php Adds trailing comma to constructor parameters
tests/bootstrap.php Removes unused constant definitions
phpcs.xml Removes deprecated installed_paths configuration
.github/workflows/pull-request.yml Updates PHP version to 8.4 and improves version testing strategy
.github/workflows/master.yml Updates PHP version to 8.4

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

run: |
composer self-update
rm -rf composer.lock
composer install --prefer-dist --no-interaction --no-progress
Copy link

Copilot AI Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sequence of commands is inefficient: composer install is immediately followed by composer update, making the install step redundant. Since composer.lock is removed, running composer update alone would be sufficient. Consider removing line 29 to avoid unnecessary work.

Suggested change
composer install --prefer-dist --no-interaction --no-progress

Copilot uses AI. Check for mistakes.
@cnizzardini cnizzardini merged commit 7df69cd into master Oct 22, 2025
4 checks passed
@cnizzardini cnizzardini deleted the update-class-finder branch October 22, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants