Open
Conversation
Replace "Biome.HELL" with "Biome.NETHER" in three places near line 126. This should break 1.12.2 and older compatibility, but fix an issue with 1.13.2.
Prepared for Bukkit 1.13.2, Java 1.8 and changed version.
I don't think this file actually matters as eclipse sucks and you should use notepad++
Again with this eclipse shit? Just use Notepad++
added useful info.
Unless I did this right, in which case it'll work even better!
Then this surely won't. Though, the created config.yml is not from this file (yet) and will not include all of these lines. Thanks yaml parsing.
I think. Maybe it won't break everything. I hope.
Let's see if it compiles now.
Because I don't feel like learning to re-code the entire loot system for AngryWolves, or making it depend on SlimeFun for heart refills.
Owner
|
I'll give this a look - thanks for the effort, though! Hopefully, I'll be able to merge it over the weekend |
Author
|
No worries. I think my players like the gapples lok :o |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This may still be broken. I've updated various bits for 1.13.2.
I've also hard-coded GOLDEN_APPLE as the only drop, for now.
I would eventually like to have a soft depend for SlimeFun to drop various slimefun items, including Hearts, Heart Canister (slim chance), and LuckyBlocks. If possible.