-
Notifications
You must be signed in to change notification settings - Fork 86
**Add Multi-Platform Build and Signing Support for VS Code Python Debugger Extension** #927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bschnurr
wants to merge
54
commits into
main
Choose a base branch
from
add-platforms
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p download + wheel extraction, instead of urllib.request.urlopen() against the pinned URLs in debugpy_info.json. This makes the download respect your pip configuration (proxy, internal index/mirror, certs) and avoids hard-coded files.pythonhosted.org URLs. Added _infer_debugpy_version() so the build can still determine which debugpy==... to download: uses DEBUGPY_VERSION if set, otherwise parses the version out of debugpy_info.json (so you don’t have to change version management right now). Added download_debugpy_via_pip() which downloads the appropriate wheels for the target: If VSCETARGET is win32-x64, linux-x64, or darwin*, it downloads cp310/cp311/cp312 wheels for that platform (same intent as the old JSON approach). If VSCETARGET is missing/unknown, it downloads the universal none-any wheel via a valid pip “target tag” (--python-version 39 --implementation cp --abi none --platform any). Verified locally: python -m nox --session install_bundled_libs now succeeds (after fixing the fallback pip arguments).
…dation - Add publish-extension.yml template with Sign, WaitForValidation, and Publish jobs - Add createGitHubRelease.yml template for GitHub release creation - Update publish.yml to iterate over buildPlatforms and publish each platform - Rename artifact folder from 'drop' to 'extension' - Rename pipeline stage from 'Sign' to 'Publish' - Add manual validation gate before marketplace publishing (default enabled) - Download platform-specific artifacts (vsix-universal, vsix-linux-arm64, etc.) - Extract version from VSIX filename for GitHub release tagging
…iles" ``` ``` Done. Updated folder usage is now: | Folder | Purpose | |--------|---------| | `$(Build.BinariesDirectory)/vsix-*` | Downloaded VSIX inputs | | `$(Agent.TempDirectory)/vsix-extracted` | Temporary extraction for reading version | | `$(Build.StagingDirectory)\extension` | Signing working directory & output artifact | | `$(Build.ArtifactStagingDirectory)` | Reserved for final artifact staging (Publish job) | Made changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces comprehensive multi-platform build, signing, and publishing support for the Python Debugger extension, along with improvements to how debugpy dependencies are downloaded during the build process.
Key Changes
🏗️ Multi-Platform Build Pipeline
linux-x64,linux-arm64,linux-armhfdarwin-x64,darwin-arm64win32-x64,win32-arm64🔐 Enhanced Signing Pipeline
📦 Improved Dependency Management (noxfile.py)
pip downloadfor fetching debugpy wheelsdownload_debugpy_via_pip()function respects pip configuration (proxy, internal index/mirror, certs)_parse_wheel_info()to extract version and platform info from wheel URLsfiles.pythonhosted.orgdirectly🚀 Publishing Improvements
v{version})📝 Other Changes
@vscode/vsceto latest version in package.jsonpublishExtensionparameter)Pipeline Flow
Testing
nox --session install_bundled_libsworks with pip-based downloadsBreaking Changes
Note: this break previous pipelines due to checking in loc files