-
Notifications
You must be signed in to change notification settings - Fork 331
Add CSV encoding tests for enum and extensible enum arrays #9390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: tadelesh <[email protected]>
commit: |
|
All changed packages have been documented.
Show changes
|
XiaofeiCao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit, should we consider edge cases, e.g. empty array("")?
weidongxu-microsoft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've had a simple one. #9330
But fine to use this more complete case.
Sorry for not noticing your PR. Let me close your one. |
|
@timotheeguerin Could you help to reivew? |
Adds spector scenario tests for enum arrays and union-as-enum arrays with CSV delimiters, following the existing string array test pattern.
Changes
Colorsfixed enum andColorsExtensibleEnumunion for test data@encode(ArrayEncoding.*)decorators@scenariooperations testing request/response roundtrip for each delimiter typeExample
All tests validate that enum arrays serialize as delimited strings (e.g.,
"blue,red,green") rather than JSON arrays.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.