Added "Size" property to the disks for Windows systems #612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 30, 2025 10:01
This reverts commit da5f753.
nchapagain001
approved these changes
Jan 6, 2026
nchapagain001
approved these changes
Jan 7, 2026
brdeyo
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linux disks always include a "size" property even when there are no volumes/partitions for the disk. However, Windows disks DO NOT include a "Size" property at any point.
Following is the telemetry snippet after the changes on a win-x64 VM:
"disksToTest": [
{
"index": 1,
"devicePath": "\\.\PHYSICALDISK1",
"properties": {
"model": "",,,
"crashdump Disk": "No",
"clustered Disk": "No",
"index": 1,
"size": "880 GB"
},