Add option textfiltermode=keep-selection #3974
Open
+17
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background:
The
textfiltercommand is great for running a single shell command on a selection (or multiple) from the buffer as stdin. The selection is replaced by the command output, but the output is not selected afterward.Expected changes:
textfiltermode=keep-selectionto keep the output selected. This is great for chaining commands and in line with what I would expect textfilter to do.textfiltermode=drop-selection)Personal note: I am new to the code base and never written Go. I find the repo very easy to work with. I might have implemented this in a completely stupid way though. Harsh feedback is welcome. I could have made this into a plugin, but I found it hard to implement the textfilter command in Lua, so went with this native approach instead. If this approach is approved, then I will oversee the documentation as well.