-
Notifications
You must be signed in to change notification settings - Fork 20
Add LlamaDemo Android instrumentation test workflow with model presets #149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+152
−68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run emulator-based instrumentation tests on Ubuntu 24.04 runner with: - KVM hardware acceleration - X11/graphics library dependencies for headless emulator - Android SDK setup via android-actions/setup-android - AVD caching for faster subsequent runs
lucylq
approved these changes
Jan 15, 2026
…llm-android-ubuntu-runner
This reverts commit f63ee53.
When targetName equals sourceName (e.g., both are tokenizer.model), localPath and tempForChecksum point to the same file. The checksum verification was deleting this file, causing the subsequent push to fail with "No such file or directory". Now we check if a copy is needed and only delete if we made a copy.
The saveLogs() method was directly iterating over the logs ArrayList with Gson while another thread could be adding logs via ETLogging.log(). This caused a ConcurrentModificationException during activity destroy. Fix by creating a defensive copy of the list before serialization.
- Use RAM_SIZE env var in Configure AVD RAM step - Remove redundant ram-size and -memory emulator options - Remove meminfo debug output - Keep directory clearing for fresh model files each run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Workflow (
.github/workflows/llm-android.yml)8-core-ubuntuwith KVM acceleration for emulatorworkflow_dispatch:stories(default): Small 110M stories model from S3llama: Llama-3.2-1B from HuggingFaceqwen3: Qwen3-4B-INT8-INT4 from HuggingFacecustom: User-provided model and tokenizer URLsGradle (
llm/android/LlamaDemo/app/build.gradle.kts)-PmodelPresetproperty-PcustomPteUrland-PcustomTokenizerUrlTest plan
storiespreset - verify tests passllamapreset (requires sufficient emulator RAM)qwen3preset