Changes to get Wireless paper Voltage.#1574
Changes to get Wireless paper Voltage.#1574RichardPar wants to merge 2 commits intomeshcore-dev:mainfrom
Conversation
|
Why You named it HeltecV3WirelessPaper? It is HeltecWirelessPaper. |
|
The documentation from Heltec states its based on the Heltec v3 platform - hence why I kept v3 in its naming. I didnt want a v4 with the same name causing confusion. Richard |
|
@RichardPar for me this is confusing. In the flasher the board is named "Heltec Wireless Paper", heltec also names it "Wireless Paper" https://docs.heltec.org/en/node/esp32/wireless_paper/index.html It would be confusing if it now shows "Heltec V3 Wireless Paper" in the hardware info. IMHO the name should stay "Heltec Wireless Paper". What about an approach to add the ADC_MULTIPLIER to the v3 board.h and just use it in the WirelessPaper? |
Changed to Heltec Wireless Paper
Updated- I didn't want to touch the base V3 code as I don't know what its impact would be. I didn't want to rock the boat. |
|
I made the fix way easier, look #1584 |
Thanks! it is far easier, I'll close this one. |
This changes the Helltec wireless paper battery voltage. its full scale is 4.2V and scaling. the previous formula returned 0 for some reason.