feat: allow collecting agents reporters by unique id #195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…-frames into data-collector
Author
|
@Ben-geo & @adamamer20 I am getting some troubles passing the CI tests, can you look into it and suggest me what can I do next? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR :-
Modified
DataCollector._collect_agent_reportersindatacollector.pyto automatically retrieve and store theunique_idcolumn for every active AgentSet before collecting user-defined reporters.Motive
When collecting agent reporters (e.g., wealth), the current implementation only collects the values of the requested column but not the unique agent IDs. This makes it difficult to trace values back to the corresponding agent, especially when debugging, analyzing distributions, or joining with other data sources.