Fix schema validation for duration_typical null values #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements MCP server icons at the correct architectural level (server initialization) instead of at the tool level. Adds both light and dark theme variants of the Mapbox logo using base64-encoded SVG data URIs. - Add mapbox-logo-black.svg for light theme backgrounds - Add mapbox-logo-white.svg for dark theme backgrounds - Update server initialization to include icons array with theme property - Use 800x180 SVG logos embedded as base64 data URIs This replaces the previous incorrect approach of adding icons to individual tools, which was not aligned with the MCP specification. Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Updates the MCP SDK from 1.25.1 to 1.25.2 and recreates the output validation patch for the new version. The patch continues to convert strict output schema validation errors to warnings, allowing tools to gracefully handle schema mismatches. Changes: - Update @modelcontextprotocol/sdk from ^1.25.1 to ^1.25.2 - Recreate SDK patch for version 1.25.2 - Remove obsolete 1.25.1 patch file - All 397 tests pass with new SDK version Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
…lues The Mapbox Directions API can return duration_typical and weight_typical as null in some cases, but our schema validation was incorrectly defined as z.number().optional() which only allows the field to be omitted, not null. This caused validation errors when the API returned these fields as null: "data.routes[0].duration_typical should be number" Changes: - Updated DirectionsTool.output.schema.ts to use .nullable().optional() for duration_typical and weight_typical in RouteSchema, RouteLegSchema, and RouteStepSchema - Updated cleanResponseData.ts RawRoute interface to allow null values for duration_typical and weight_typical This fix allows the tool to correctly handle API responses where these fields are null. Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
mattpodwysocki
added a commit
that referenced
this pull request
Jan 15, 2026
Same fix as PR #100 - allows duration_typical and weight_typical to be null. This fixes the validation error when declining elicitations and getting routes with null duration_typical values from the API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a schema validation error that occurs when the Mapbox Directions API returns
duration_typicalorweight_typicalasnull.Problem
The API can return these fields as
nullin certain cases, but our Zod schema was defined asz.number().optional()which only allows the field to be omitted entirely, not set tonull. This caused validation errors:Solution
Updated the schema to use
.nullable().optional()for these fields in:RouteSchemaRouteLegSchemaRouteStepSchemaAlso updated the TypeScript
RawRouteinterface to allow null values.Testing
Files Changed
src/tools/directions-tool/DirectionsTool.output.schema.ts- Updated Zod schemassrc/tools/directions-tool/cleanResponseData.ts- Updated TypeScript interface🤖 Generated with Claude Code