Don't process default methods at all#162
Open
jtulach wants to merge 3 commits intoluontola:masterfrom
Open
Conversation
Author
|
Is there any chance this PR gets in and a new release is crafted anytime soon? Or shall I fork my own copy of Retrolamda into Bck2Brwsr VM? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi.
I am trying to upgrade Bck2Brwsr VM usage of Retrolamda from 2.1.0 to 2.5.7. I am facing problems. Bck2Brwsr doesn't need help with default methods, only with lambdas. Looks like that version 2.5.7 isn't really ready for that.
This change, together with 3a5bb2a change seem to do the trick. Can you please review them and accept or suggest better way to do what is necessary?
One surprising issue is that I have to call analyzer.analyse myself as it is not called when
defaultMethodsEnabledisfalse.Then I needed to somehow disable creation of the companion class. The
protectedmethod which allows me to return existing class name seems to do the trick.My changes just outline what is necessary. I am sure you can come up with better fixes.
Btw. it maybe hard to test with
defaultMethodsEnabledbeing off - if you are interested, I could prepare some testcase using Bck2Brwsr AOT compilation & execution. It might make upgrading to new retrolambda version less painful in the future.