Add helpers for tracing attributes. #1363
Merged
+52
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e60c173 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR 💥 An error occurred when fetching the changed packages and changesets in this PR |
boks1971
approved these changes
Jan 13, 2026
paulwe
approved these changes
Jan 13, 2026
| TraceKeySIPPrefix = TraceKeyPref + "sip." | ||
| TraceKeySIPHeaderPrefix = TraceKeySIPPrefix + "h." | ||
| TraceKeySIPCallID = attribute.Key(TraceKeySIPPrefix + "callID") | ||
| TraceKeySIPCallIDHeader = attribute.Key(TraceKeySIPHeaderPrefix + "CallID") |
Contributor
There was a problem hiding this comment.
key case. also should these be call.id?
Contributor
Author
There was a problem hiding this comment.
This just follows the name of the header in this case. Maybe the first one (non-header) should have dot as well. Let me fix that.
Contributor
There was a problem hiding this comment.
if we were following existing conventions wouldn't all of them be camel case?
This was referenced Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.