⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Conversation

@hiroshihorie
Copy link
Member

@hiroshihorie hiroshihorie commented Jan 24, 2026

Summary by CodeRabbit

  • Bug Fixes
    • Fixed mute state synchronization to ensure the client's local mute status remains in sync with the server, preventing inconsistencies during track publishing and codec operations.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 24, 2026

📝 Walkthrough

Walkthrough

Adds a changelog entry for a mute state synchronization fix. Introduces an overrideable updateFromInfo() method to LocalParticipant that reconciles the local mute state with the server's ParticipantInfo, sending updates to the server if they differ. Also propagates the muted state to AddTrackRequest calls for backup codec publication.

Changes

Cohort / File(s) Summary
Changelog
.changes/reconcile-local-mute-state
Added fixed-type changelog entry documenting mute state synchronization fix.
Local Participant Mute Reconciliation
lib/src/participant/local.dart
Introduced updateFromInfo() method to reconcile local mute state with server's ParticipantInfo and send corrections if diverged. Extended backup codec publication to include the local track's muted state in AddTrackRequest invocations.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

  • #963: Both PRs modify lib/src/participant/local.dart to propagate the local track's muted state into AddTrackRequest for preserving server-side mute state.

Poem

🐰 A mute state sync, so clean and tight,
Local whispers match the server's light,
No more echoes of a scattered sound,
Harmony in silence, peace profound! 🤫

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Ensure mute state stays in sync after reconnect' directly aligns with the main change: reconciling local mute state with the server after reconnection.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch hiroshi/align-mute

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 88f69f3 and 82f1d39.

📒 Files selected for processing (1)
  • .changes/reconcile-local-mute-state
🚧 Files skipped from review as they are similar to previous changes (1)
  • .changes/reconcile-local-mute-state
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
  • GitHub Check: Build for Flutter Web WASM
  • GitHub Check: Build for Flutter Linux
  • GitHub Check: Build for Flutter Windows
  • GitHub Check: Build for Flutter Web
  • GitHub Check: Build for Flutter iOS
  • GitHub Check: Build for Flutter macOS
  • GitHub Check: Build for Flutter Android

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@hiroshihorie hiroshihorie merged commit 690f276 into main Feb 1, 2026
17 checks passed
@hiroshihorie hiroshihorie deleted the hiroshi/align-mute branch February 1, 2026 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants