-
-
Notifications
You must be signed in to change notification settings - Fork 280
initial env var ingestion for rev proxy configs #586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
I am a bot, here is the pushed image/manifest for this PR:
|
|
I am a bot, here is the pushed image/manifest for this PR:
|
|
Made the env tamplates directory a dedicated thing so it will not delete anyone's custom configs. |
|
I am a bot, here is the pushed image/manifest for this PR:
|
|
I am a bot, here is the pushed image/manifest for this PR:
|
|
This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions. |
I have tested this pretty thoroughly at this point, it is bolt on logic so will not have an effect on any existing setups unless you can think of any possible reason someone would be passing an env var starting with "PROXY_CONFIG_" to a swag container.
The most basic string is incredibly useful to do subdomain setup to a port using a service name as :
This basically just works in most cases subdomain to a port, but all the options are there to get way more complex like in the case of Plex:
The docced examples show the - array member syntax with escaped $ being double $$ and the whole thing being wrapped in single quotes but the object syntax like the plex example above is much more forgiving.
I think this is a good first step and maybe down the line we can look at using jinja templates for the ini generation and get everything in an env var format if possible.