Use dedicated storage types instead of proto defintions #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were storing payments and forwarded payments just using our proto definitions as the encoding. While this works, this will make updating the storage and/or the proto defintion harder as we have to respect backwards compatability for both. Splitting these out into two separate defintions will make this easier and safer in the future.
|
👋 Thanks for assigning @tnull as a reviewer! |
The impl_writeable_tlv_based macro always creates this warning so we ignore it in CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were storing payments and forwarded payments just using our proto definitions as the encoding. While this works, this will make updating the storage and/or the proto defintion harder as we have to respect backwards compatability for both. Splitting these out into two separate defintions will make this easier and safer in the future.