⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Conversation

@benthecarman
Copy link
Collaborator

Used /init in claude code to make initial structure than added some notes myself.

@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Jan 22, 2026

I've assigned @joostjager as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

Copy link
Contributor

@joostjager joostjager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you see claude change behavior with this file present?

- Hard tabs, max width 100 chars
- Imports grouped: std, external crates, local crates

## Development Rules
Copy link
Collaborator

@tnull tnull Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could mention "Always ensure that tests pass and lints are fixed before committing". Also, maybe, "run cargo +nightly fmt before committing if nightly channel Rust is locally installed already"? Or do you feel such things rather belong in the local/personal CLAUDE.md?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather not put the nightly fmt in here. If we merge a PR without it, we don't want someone else's PR formatting other unrelated code

@joostjager
Copy link
Contributor

Apparently this file is loaded into the context at the start of every session. Recommendation is too keep it short and only have it contain non-obvious things.

Used /init in claude code to make initial structure than added some
notes myself.
@benthecarman
Copy link
Collaborator Author

Simplified claude.md a lot and made a contributing.md that has more details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants