⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Go 1.8: Implement support ColumnConverter interface #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kshvakov wants to merge 5 commits into from
Closed

Go 1.8: Implement support ColumnConverter interface #624

kshvakov wants to merge 5 commits into from
+137 −0

Conversation

@kshvakov
Copy link

@kshvakov kshvakov commented Jun 9, 2017

Hi, this is implementation of ValueConverter interface for providing the ConvertValue method

@kshvakov kshvakov changed the title Implement support ColumnConverter interface Go 1.8: Implement support ColumnConverter interface Jun 9, 2017
ainar-g
ainar-g approved these changes Oct 21, 2017
View reviewed changes
ainar-g
ainar-g approved these changes Oct 21, 2017
View reviewed changes
Copy link
Contributor

@ainar-g ainar-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Travis fail is a fluke. The maintainters will probably ask you to rebase and squash your commits into one.

@kshvakov
Copy link
Author

kshvakov commented Oct 25, 2017

Hello, branch is rebased

arp242 added a commit that referenced this pull request Jan 19, 2026
@arp242
Handle uint64 in NAmedValueChecker
2e638e5 
So that scanning uint64 from e.g. numeric or text columns works.

Fixes #453
Fixes #624
arp242 added a commit that referenced this pull request Jan 19, 2026
@arp242
Handle uint64 in NamedValueChecker
712e6b8 
So that scanning uint64 from e.g. numeric or text columns works.

Fixes #453
Fixes #624
@arp242 arp242 mentioned this pull request Jan 19, 2026
Merged
@arp242 arp242 closed this in fc449c6 Jan 19, 2026
@arp242
Copy link
Collaborator

arp242 commented Jan 19, 2026

This was added in #1125 and #1238 with CheckNamedValue(), which does the same as the (now-deprecated) ColumnConverter().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ainar-g ainar-g ainar-g approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kshvakov @arp242 @ainar-g