Conversation
docs/dev/index.html
Outdated
| <li><a href="#start">Getting Started</a></li> | ||
| <li><a href="#reference">Reference</a></li> | ||
| <li><a href="#community">Community</a></li> | ||
| <li><a href="/dev/community.html">Community</a></li> |
There was a problem hiding this comment.
Let's not make these absolute paths, so that it will work once the page is promoted from dev to release.
docs/dev/index.html
Outdated
| </div> | ||
| <div class="col-lg-4 col-md-4 col-xs-12 text-center highlight-module"> | ||
| <a href="/dev/community/"><span class="mega-octicon octicon-git-pull-request"></span></a> | ||
| <a href="/dev/community.html/"><span class="mega-octicon octicon-git-pull-request"></span></a> |
There was a problem hiding this comment.
- There should not be a trailing slash after the ".html".
- Same comment here about "/dev/community.html" -> "community.html"
| <div class="col-lg-4 col-md-4 col-xs-12 text-center highlight-module"> | ||
| <a href="/dev/community/"><span class="mega-octicon octicon-git-pull-request"></span></a> | ||
| <a href="/dev/community.html/"><span class="mega-octicon octicon-git-pull-request"></span></a> | ||
| <h2><a href="/dev/community/">Community</a></h2> |
There was a problem hiding this comment.
This link should also get the new link.
| @@ -0,0 +1,223 @@ | |||
| <!DOCTYPE html> | |||
There was a problem hiding this comment.
So ... this is a lot of duplication of the index.html. We should use https://github.com/erlydtl/erlydtl instead. LFE Dragon uses erlydtl. Check out the following:
- https://github.com/lfe/docs/tree/master/priv/templates
- https://github.com/lfex/poise (this is called in
docs-gen) - https://github.com/lfe/docs/blob/master/src/docs-pages.lfe (in particular, the
('landing path)clause which generates the dev index page ... this can serve the basis of the new community page)
Let's keep this PR open, and we'll just iterate here, as you push your changes for my review.
This is a good start :-)
(more comments below)
There was a problem hiding this comment.
Hi, i'm kind of confused because of my unfamiliarity with the tool. Can you tell me a correct way to generate new community.html?
should I do: (docs-pages:get-page 'landing '/dev/community.html) ??
There was a problem hiding this comment.
It's a bit more involved; you'll have to look at how the landing page is done. I can review that, but it will be a week or two (I'm in the middle of a move and don't have the chunks of time needed to instruct on this).
docs/dev/community.html
Outdated
| <ul> | ||
| <li>The LFE/LFEX <a href="http://plan.lfe.io/">.plan</a> file</li> | ||
| <li>An <a href="http://blog.lfe.io/">LFE news, tutorials, and updates blog</a></li> | ||
| <li><a href="http://rvirding.blogspot.com/">Robert Virding's blog</a></li> |
There was a problem hiding this comment.
You can re-add my blog from here (just LFE-specific posts):
|
Thanks for the review @oubiwann. I will start working on it! |
|
@oubiwann hey, I updated my pull request. Please review if you have enough time! |
|
Hey @oubiwann, do you have time for this one? It's been long! |
2 participants
fix for #99
part of epic #98
Had to remove @oubiwann's blog because it is inaccessible. There might be problems with CSS as I'm not a frontend dev. Please review.