change doctest to always include <ostream>#175
Closed
andreasbuhr wants to merge 1 commit intolewissbaker:masterfrom
Closed
change doctest to always include <ostream>#175andreasbuhr wants to merge 1 commit intolewissbaker:masterfrom
andreasbuhr wants to merge 1 commit intolewissbaker:masterfrom
Conversation
On MSVC 1928, doctest.h fails to compile if <ostream> was not included before. In the code was a statement that a similar problem existed with clang before. This patch changes doctest.h to always include <ostream>.
lewissbaker
reviewed
Oct 12, 2020
Owner
lewissbaker
left a comment
lewissbaker
left a comment
There was a problem hiding this comment.
In the 'vs2019' branch I ended up just upgrading doctest to a later version which I think fixes a bunch of issues with MSVC 2019 builds.
Would upgrading doctest to a later version be a better approach than trying to patch this old version?
Comment on lines
-435
to
-437
| #else // DOCTEST_CONFIG_USE_IOSFWD | ||
| #include <iosfwd> | ||
| #endif // DOCTEST_CONFIG_USE_IOSFWD |
Owner
There was a problem hiding this comment.
Should you still be preserving the semantics of the DOCTEST_CONFIG_USE_IOSFWD macro?
Contributor
Author
|
I agree. Updating doctest is better than patching the old one. I created a pull request for this in #178 but that still needs more testing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On MSVC 1928, doctest.h fails to compile if was not
included before. In the code was a statement that a similar problem
existed with clang before.
This patch changes doctest.h to always include .