Using ChunkStatus.SURFACE insteadof null#815
Open
gisellevonbingen wants to merge 2 commits intoldtteam:version/mainfrom
Open
Using ChunkStatus.SURFACE insteadof null#815gisellevonbingen wants to merge 2 commits intoldtteam:version/mainfrom
gisellevonbingen wants to merge 2 commits intoldtteam:version/mainfrom
Conversation
|
|
Nightenom
reviewed
Jan 27, 2026
| private OurWorldGenRegion(ServerLevel p_143484_, List<ChunkAccess> p_143485_) | ||
| { | ||
| super(p_143484_, p_143485_, null, -1); | ||
| super(p_143484_, p_143485_, ChunkStatus.EMPTY, -1); |
Member
There was a problem hiding this comment.
Use SURFACE please, it's not used by vanilla anyway in 1.20
gisellevonbingen
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
Closes #
Changes proposed in this pull request
Testing
Crashed code.
https://github.com/RelativityMC/C2ME-fabric/blob/4e4b37e5848f70a4b53776d59263f831c6a7d113/c2me-threading-worldgen/src/main/java/com/ishland/c2me/threading/worldgen/mixin/MixinChunkRegion.java#L41-L44
The parameter what type is
ChunkStatusis not marked as nullable.I think using
ChunkStatus.EMPTYis better thannulleven if it is no used anywhere in vanilla.Review please