fix wrong cycle detect by clone the map[visit]int#95
Open
fix wrong cycle detect by clone the map[visit]int#95
Conversation
Author
|
this is only a draft PR, and i will code more to try fix this. cc @kr btw, thanks for this great repo. |
Owner
|
Good catch, thank you! I just opened #96 for the bug itself. That should automatically be closed when this PR gets merged. |
1972968 to
b801321
Compare
b801321 to
e042962
Compare
Author
|
cc @kr I have add a clone func to copy the visited map, and add some test about cycle |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use
visited map[visit]intto check cycle might get some bad case.the key reason was that, all the
pp,pprintershare a samemap[visit]intbut when we process a struct refer a pointer value twice or more, this is not a cycle, it's just a repeat refer.
maybe use other helper data type for every branch when we call code
pp = *pstatementmaybe a
sliceis enough to detect.only branch3 should print a "CYCLIC REFERENCE"