Add type string to show the different type and value#52
Open
AvengerMoJo wants to merge 1 commit intokr:masterfrom
Open
Add type string to show the different type and value#52AvengerMoJo wants to merge 1 commit intokr:masterfrom
AvengerMoJo wants to merge 1 commit intokr:masterfrom
Conversation
Signed-off-by: Alex Lau (AvengerMoJo) <alau@suse.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some case, when you compare the type and package.type even the value are completely the same. The type is consider different.
In order to display the different is not in the value but the type itself, we need to print out both the type and package.type in the error message to allow better understanding of the situation