Replace liftM and liftM2 with fmap and liftA2 respectivally#93
Open
jappeace wants to merge 2 commits intojswebtools:masterfrom
Open
Replace liftM and liftM2 with fmap and liftA2 respectivally#93jappeace wants to merge 2 commits intojswebtools:masterfrom
jappeace wants to merge 2 commits intojswebtools:masterfrom
Conversation
it's to solve build errors like these on ghc 9.8.4: ``` language-ecmascript> src/Language/ECMAScript3/Syntax.hs:327:21: error: [GHC-88464] language-ecmascript> Variable not in scope: language-ecmascript> liftM2 language-ecmascript> :: (Bool -> Bool -> Bool) language-ecmascript> -> State ([Label], [EnclosingStatement]) Bool language-ecmascript> -> State ([Label], [EnclosingStatement]) Bool language-ecmascript> -> State ([Label], [EnclosingStatement]) Bool language-ecmascript> Suggested fix: language-ecmascript> Perhaps use one of these: language-ecmascript> ‘liftA2’ (imported from Prelude), language-ecmascript> ‘lift’ (imported from Control.Monad.State), language-ecmascript> ‘liftIO’ (imported from Control.Monad.State) language-ecmascript> | language-ecmascript> 327 | IfStmt _ _ t e -> liftM2 (&&) (checkStmtM t) (checkStmtM e) language-ecmascript> | ^^^^^^ language-ecmascript> language-ecmascript> src/Language/ECMAScript3/Syntax.hs:329:37: error: [GHC-88464] language-ecmascript> Variable not in scope: language-ecmascript> liftM2 language-ecmascript> :: (Bool -> Bool -> Bool) language-ecmascript> -> State ([Label], [EnclosingStatement]) Bool language-ecmascript> -> a0 language-ecmascript> -> State ([Label], [EnclosingStatement]) Bool language-ecmascript> Suggested fix: language-ecmascript> Perhaps use one of these: language-ecmascript> ‘liftA2’ (imported from Prelude), language-ecmascript> ‘lift’ (imported from Control.Monad.State), language-ecmascript> ‘liftIO’ (imported from Control.Monad.State) language-ecmascript> | language-ecmascript> 329 | TryStmt _ body mcatch mfinally -> liftM2 (&&) (checkStmtM body) $ ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it's to solve build errors like these on ghc 9.8.4:
Also bumps the bounds