Remove improper < HTML entity workaround no longer needed#259
Open
NReilingh wants to merge 2 commits intojsdoc:mainfrom
Open
Remove improper < HTML entity workaround no longer needed#259NReilingh wants to merge 2 commits intojsdoc:mainfrom
< HTML entity workaround no longer needed#259NReilingh wants to merge 2 commits intojsdoc:mainfrom
Conversation
This is a markdown code block, so manually escaping HTML entities is incorrect as they will just be re-escaped.
These were added when the SSG did not handle HTML in markdown code blocks properly Eleventy appears to work correctly now
|
The issue fixed by this PR makes some of the examples a bit confusing. I think this should be merged with priority. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These
<show up at https://jsdoc.app/tags-example and various other pages on the frontend. I believe they were originally a workaround for some markdown parser not generating HTML correctly.I have tested this locally against the current in-use eleventy SSG and the raw
<in the MD code block is handled appropriately now.