Cleanup for type checking #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR simplifies type-checking setup by removing special-case ty configuration and instead suppressing type warnings locally in py_cppmodel.py, while also cleaning up an unused dev dependency from the lockfile.
Changes:
- Removed the
parameterizedpackage fromuv.lock(package entry + dev dependency references). - Dropped the
tool.ty.overridesblock frompyproject.toml. - Updated
py_cppmodel.pyto aliasclang.cindex“kind” enums and re-expose them asAny-typed names to avoid type-checker attribute warnings.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
uv.lock |
Removes parameterized from locked packages and dev dependency metadata. |
pyproject.toml |
Removes the ty override that ignored unresolved attributes for py_cppmodel.py. |
py_cppmodel.py |
Adds Any-typed re-exports for clang.cindex kind/enum objects to keep type checking clean without global overrides. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.