Get version tag from GIT when parameter not given #693
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes version tag retrieval from Git when building locally without explicitly providing a tag parameter. The issue was that the gradle-git library API had changed or was being used incorrectly, causing warnings during local builds.
Key Changes:
- Upgrades gradle-git dependency from version 1.2.0 to 1.6.0
- Adds null-safe access to the tag name property with a fallback to "no-tag"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
version.gradle
Outdated
| jmeGitTag = project.getProperty("tag_name") | ||
| } else { | ||
| jmeGitTag = grgit.tag.list().find { it.commit == head } | ||
| jmeGitTag = grgit.tag.list().find { it.commit == head }?.name ?: "no-tag" |
There was a problem hiding this comment.
Using "no-tag" as the default value will cause getReleaseInfo() to print warning messages about an erroneous tag since it doesn't match the expected version format. Consider using an empty string "" or null instead, which getReleaseInfo() explicitly handles at lines 60-63 by returning null without warnings.
| jmeGitTag = grgit.tag.list().find { it.commit == head }?.name ?: "no-tag" | |
| jmeGitTag = grgit.tag.list().find { it.commit == head }?.name ?: "" |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1 participant
Ok, this is a small thing. But locally, if you just do Gradle buildSdk, it tries to get the version from GIT tags. Well, seems it hasn't worked for awhile (or just broken recently with all the Gradle upgrades?). It gives a nasty warning while building. Release build always gives the tag so no problem there.