⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
e729dea
feat(chip): add recipe and variables
thetaPC Dec 15, 2025
0d6bd9d
Update core/src/components/chip/chip.tsx
thetaPC Dec 16, 2025
ade5c05
Update core/src/utils/theme.ts
thetaPC Dec 16, 2025
0349ff7
Update core/src/utils/theme.ts
thetaPC Dec 16, 2025
ee81a8a
fix(theme): remove extra curly bracket
thetaPC Dec 16, 2025
c6dfb10
refactor(theme): remove root
thetaPC Dec 16, 2025
e795c61
chore(components): run build
thetaPC Dec 16, 2025
39bfce5
chore(many): run lint
thetaPC Dec 16, 2025
b67f4f5
test(theme): add more generateComponentsThemeCSS tests
thetaPC Dec 16, 2025
9ecb103
Update core/src/themes/mixins.scss
thetaPC Dec 16, 2025
7040091
refactor(theme): seperate objects
thetaPC Dec 16, 2025
098cba4
feat(chip): adding ionic theme
thetaPC Dec 18, 2025
55b610a
feat(themes): add ionic
thetaPC Jan 9, 2026
918582b
refactor(themes): optimize chip recipe
thetaPC Jan 12, 2026
3e5236c
refactor(chip): remove majority usage of Sass vars
thetaPC Jan 12, 2026
b90fe18
feat(theme): add ios recipe
thetaPC Jan 12, 2026
2f71c0a
feat(themes): add styles
thetaPC Jan 13, 2026
32c7471
docs(chip): update prop comments
thetaPC Jan 13, 2026
da0a9a6
test(chip): update shape snapshots
thetaPC Jan 13, 2026
28d61aa
test(chip): update size snapshots
thetaPC Jan 13, 2026
d616dee
fix(chip): use correct variable
thetaPC Jan 13, 2026
2c9b1f1
test(chip): update hue snapshots
thetaPC Jan 13, 2026
d830d48
test(chip): update states snapshots
thetaPC Jan 13, 2026
68a19fd
feat(theme): add outline semantic for ios
thetaPC Jan 13, 2026
fdaafcd
test(chip): update basic snapshots
thetaPC Jan 13, 2026
c07ef36
test(chip): update a11y snapshots
thetaPC Jan 14, 2026
b419a9c
test(chip): update size snapshots
thetaPC Jan 14, 2026
3111d64
test(chip): update hue snapshots
thetaPC Jan 14, 2026
0db9f57
chore(chip): run lint
thetaPC Jan 14, 2026
ef79c8d
feat(themes): update subtle values for ios and md chip
thetaPC Jan 14, 2026
626bace
refactor(themes): update chip icon and avatar keys
thetaPC Jan 14, 2026
92edc69
chore(themes): improve chip styles
thetaPC Jan 15, 2026
beaf349
refactor(themes): use minHeight instead
thetaPC Jan 15, 2026
4dd7e23
refactor(chip): move typography to base
thetaPC Jan 15, 2026
61dce8e
docs(theme): add comments for utils
thetaPC Jan 15, 2026
e36b9bb
docs(themes): add comments for the avatar and icon
thetaPC Jan 15, 2026
94b9288
refactor(themes): round values
thetaPC Jan 15, 2026
98bf385
test(chip): update snapshots
thetaPC Jan 15, 2026
401ef1f
refactor(theme): use variables
thetaPC Jan 15, 2026
683093d
chore(core): run build
thetaPC Jan 15, 2026
ee18ef3
feat(themes): remove themes from chip logic
thetaPC Jan 15, 2026
cf6a2fd
Merge branch 'ionic-modular' of github.com:ionic-team/ionic-framework…
thetaPC Jan 15, 2026
c680ee2
feat(chip): add cursor
thetaPC Jan 15, 2026
95aeea4
test(avatar): update chip snapshots
thetaPC Jan 15, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 7 additions & 14 deletions core/api.txt
Original file line number Diff line number Diff line change
Expand Up @@ -599,20 +599,13 @@ ion-chip,prop,disabled,boolean,false,false,false
ion-chip,prop,hue,"bold" | "subtle" | undefined,'subtle',false,false
ion-chip,prop,mode,"ios" | "md",undefined,false,false
ion-chip,prop,outline,boolean,false,false,false
ion-chip,prop,shape,"rectangular" | "round" | "soft" | undefined,undefined,false,false
ion-chip,prop,size,"large" | "small" | undefined,undefined,false,false
ion-chip,prop,theme,"ios" | "md" | "ionic",undefined,false,false
ion-chip,css-prop,--background,ionic
ion-chip,css-prop,--background,ios
ion-chip,css-prop,--background,md
ion-chip,css-prop,--border-radius,ionic
ion-chip,css-prop,--border-radius,ios
ion-chip,css-prop,--border-radius,md
ion-chip,css-prop,--color,ionic
ion-chip,css-prop,--color,ios
ion-chip,css-prop,--color,md
ion-chip,css-prop,--focus-ring-color,ionic
ion-chip,css-prop,--focus-ring-width,ionic
ion-chip,prop,shape,"rectangular" | "round" | "soft" | undefined,'round',false,false
ion-chip,prop,size,"large" | "small" | undefined,'large',false,false
ion-chip,css-prop,--background
ion-chip,css-prop,--border-radius
ion-chip,css-prop,--color
ion-chip,css-prop,--focus-ring-color
ion-chip,css-prop,--focus-ring-width

ion-col,shadow
ion-col,prop,mode,"ios" | "md",undefined,false,false
Expand Down
3 changes: 2 additions & 1 deletion core/scripts/testing/scripts.js
Original file line number Diff line number Diff line change
Expand Up @@ -128,10 +128,11 @@ const DEFAULT_THEME = 'md';
window.Ionic.config = window.Ionic.config || {};
window.Ionic.config.customTheme = theme;

// Re-apply the global theme
// Re-apply the global theme, needed for Playwright tests
if (window.Ionic.config.get && window.Ionic.config.set) {
const themeModule = await import('/themes/utils/theme.js');
themeModule.applyGlobalTheme(theme);
themeModule.applyComponentsTheme(theme);
}
} catch (error) {
console.error(`Failed to load theme tokens for ${themeName}:`, error);
Expand Down
24 changes: 10 additions & 14 deletions core/src/components.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -872,7 +872,7 @@ export namespace Components {
*/
"disabled": boolean;
/**
* Set to `"bold"` for a chip with vibrant, bold colors or to `"subtle"` for a chip with muted, subtle colors. Only applies to the `ionic` theme.
* Set to `"bold"` for a chip with vibrant, bold colors or to `"subtle"` for a chip with muted, subtle colors. Defaults to `"subtle"`.
* @default 'subtle'
*/
"hue"?: 'bold' | 'subtle';
Expand All @@ -886,17 +886,15 @@ export namespace Components {
*/
"outline": boolean;
/**
* Set to `"soft"` for a chip with slightly rounded corners, `"round"` for a chip with fully rounded corners, or `"rectangular"` for a chip without rounded corners. Defaults to `"round"` for the `"ionic"` theme and `"soft"` for all other themes.
* Set to `"soft"` for a chip with slightly rounded corners, `"round"` for a chip with fully rounded corners, or `"rectangular"` for a chip without rounded corners. Defaults to `"round"`.
* @default 'round'
*/
"shape"?: 'soft' | 'round' | 'rectangular';
/**
* Set to `"small"` for a chip with less height and padding. Defaults to `"large"` for the ionic theme, and undefined for all other themes.
* Set to `"small"` for a chip with less height and padding. Defaults to `"large"`.
* @default 'large'
*/
"size"?: 'small' | 'large';
/**
* The theme determines the visual appearance of the component.
*/
"theme"?: "ios" | "md" | "ionic";
}
interface IonCol {
/**
Expand Down Expand Up @@ -6846,7 +6844,7 @@ declare namespace LocalJSX {
*/
"disabled"?: boolean;
/**
* Set to `"bold"` for a chip with vibrant, bold colors or to `"subtle"` for a chip with muted, subtle colors. Only applies to the `ionic` theme.
* Set to `"bold"` for a chip with vibrant, bold colors or to `"subtle"` for a chip with muted, subtle colors. Defaults to `"subtle"`.
* @default 'subtle'
*/
"hue"?: 'bold' | 'subtle';
Expand All @@ -6860,17 +6858,15 @@ declare namespace LocalJSX {
*/
"outline"?: boolean;
/**
* Set to `"soft"` for a chip with slightly rounded corners, `"round"` for a chip with fully rounded corners, or `"rectangular"` for a chip without rounded corners. Defaults to `"round"` for the `"ionic"` theme and `"soft"` for all other themes.
* Set to `"soft"` for a chip with slightly rounded corners, `"round"` for a chip with fully rounded corners, or `"rectangular"` for a chip without rounded corners. Defaults to `"round"`.
* @default 'round'
*/
"shape"?: 'soft' | 'round' | 'rectangular';
/**
* Set to `"small"` for a chip with less height and padding. Defaults to `"large"` for the ionic theme, and undefined for all other themes.
* Set to `"small"` for a chip with less height and padding. Defaults to `"large"`.
* @default 'large'
*/
"size"?: 'small' | 'large';
/**
* The theme determines the visual appearance of the component.
*/
"theme"?: "ios" | "md" | "ionic";
}
interface IonCol {
/**
Expand Down
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes for ios are happening because

  • the shape default is now round instead of soft.
  • the hue default is now subtle instead of bold.

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes for md are happening because

  • the shape default is now round instead of soft.
  • the hue default is now subtle instead of bold.

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Loading