-
Notifications
You must be signed in to change notification settings - Fork 13.4k
feat(chip): add recipe and variables #30873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
thetaPC
wants to merge
44
commits into
ionic-modular
Choose a base branch
from
FW-6833
base: ionic-modular
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
e729dea
feat(chip): add recipe and variables
thetaPC 0d6bd9d
Update core/src/components/chip/chip.tsx
thetaPC ade5c05
Update core/src/utils/theme.ts
thetaPC 0349ff7
Update core/src/utils/theme.ts
thetaPC ee81a8a
fix(theme): remove extra curly bracket
thetaPC c6dfb10
refactor(theme): remove root
thetaPC e795c61
chore(components): run build
thetaPC 39bfce5
chore(many): run lint
thetaPC b67f4f5
test(theme): add more generateComponentsThemeCSS tests
thetaPC 9ecb103
Update core/src/themes/mixins.scss
thetaPC 7040091
refactor(theme): seperate objects
thetaPC 098cba4
feat(chip): adding ionic theme
thetaPC 55b610a
feat(themes): add ionic
thetaPC 918582b
refactor(themes): optimize chip recipe
thetaPC 3e5236c
refactor(chip): remove majority usage of Sass vars
thetaPC b90fe18
feat(theme): add ios recipe
thetaPC 2f71c0a
feat(themes): add styles
thetaPC 32c7471
docs(chip): update prop comments
thetaPC da0a9a6
test(chip): update shape snapshots
thetaPC 28d61aa
test(chip): update size snapshots
thetaPC d616dee
fix(chip): use correct variable
thetaPC 2c9b1f1
test(chip): update hue snapshots
thetaPC d830d48
test(chip): update states snapshots
thetaPC 68a19fd
feat(theme): add outline semantic for ios
thetaPC fdaafcd
test(chip): update basic snapshots
thetaPC c07ef36
test(chip): update a11y snapshots
thetaPC b419a9c
test(chip): update size snapshots
thetaPC 3111d64
test(chip): update hue snapshots
thetaPC 0db9f57
chore(chip): run lint
thetaPC ef79c8d
feat(themes): update subtle values for ios and md chip
thetaPC 626bace
refactor(themes): update chip icon and avatar keys
thetaPC 92edc69
chore(themes): improve chip styles
thetaPC beaf349
refactor(themes): use minHeight instead
thetaPC 4dd7e23
refactor(chip): move typography to base
thetaPC 61dce8e
docs(theme): add comments for utils
thetaPC e36b9bb
docs(themes): add comments for the avatar and icon
thetaPC 94b9288
refactor(themes): round values
thetaPC 98bf385
test(chip): update snapshots
thetaPC 401ef1f
refactor(theme): use variables
thetaPC 683093d
chore(core): run build
thetaPC ee18ef3
feat(themes): remove themes from chip logic
thetaPC cf6a2fd
Merge branch 'ionic-modular' of github.com:ionic-team/ionic-framework…
thetaPC c680ee2
feat(chip): add cursor
thetaPC 95aeea4
test(avatar): update chip snapshots
thetaPC File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
-78 Bytes
(96%)
.../basic/avatar.e2e.ts-snapshots/avatar-chip-diff-ios-ltr-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+179 Bytes
(110%)
...basic/avatar.e2e.ts-snapshots/avatar-chip-diff-ios-ltr-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-68 Bytes
(97%)
.../basic/avatar.e2e.ts-snapshots/avatar-chip-diff-ios-ltr-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+45 Bytes
(100%)
...t/basic/avatar.e2e.ts-snapshots/avatar-chip-diff-md-ltr-Mobile-Chrome-linux.png
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These changes for
|
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+250 Bytes
(110%)
.../basic/avatar.e2e.ts-snapshots/avatar-chip-diff-md-ltr-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+36 Bytes
(100%)
...t/basic/avatar.e2e.ts-snapshots/avatar-chip-diff-md-ltr-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes for
iosare happening becauseroundinstead ofsoft.subtleinstead ofbold.