-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Blackbox - remove unused setting #11236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: maintenance-10.x
Are you sure you want to change the base?
Blackbox - remove unused setting #11236
Conversation
Branch Targeting SuggestionYou've targeted the
If This is an automated suggestion to help route contributions to the appropriate branch. |
PR Compliance Guide 🔍All compliance sections have been disabled in the configurations. |
PR Code Suggestions ✨No code suggestions found for the PR. |
| .device = DEFAULT_BLACKBOX_DEVICE, | ||
| .rate_num = SETTING_BLACKBOX_RATE_NUM_DEFAULT, | ||
| .rate_denom = SETTING_BLACKBOX_RATE_DENOM_DEFAULT, | ||
| .invertedCardDetection = BLACKBOX_INVERTED_CARD_DETECTION, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this file, PG_REGISTER_WITH_RESET_TEMPLATE(blackboxConfig_t, blackboxConfig, PG_BLACKBOX_CONFIG, 4); needs to use bigger PG version or settings will be broken after flashing
Create automated check that runs on PRs to detect when parameter group structs are modified without incrementing the version number. This prevents settings corruption issues like those seen in PR iNavFlight#11236. Detection logic: - Scans changed C/H files for PG_REGISTER entries - Detects struct typedef modifications in git diff - Verifies version parameter was incremented - Posts helpful comment if version not incremented Files added: - .github/scripts/check-pg-versions.sh - Detection script - .github/workflows/pg-version-check.yml - Workflow definition - .github/workflows/README.md - Workflow documentation The check is non-blocking (comment only) to avoid false positive build failures, but provides clear guidance on when versions must be incremented.
User description
Removed invertedCardDetection settings.
Ussage of setting has been removed by digitaentity in commit
3b2f87b "Refactor SDCARD; Separate generic code from SPI-specific code"
In next commit 986980c "Convert targets to new SDCARD defines"
the setting has been replaced by "#define"
#if defined(SDCARD_DETECT_INVERTED) return !result; #else return result; #endifPR Type
Enhancement
Description
Remove unused
invertedCardDetectionsetting from blackbox configurationSetting was replaced by
SDCARD_DETECT_INVERTEDpreprocessor defineClean up struct definition, documentation, and settings configuration
Diagram Walkthrough
File Walkthrough
blackbox.h
Remove invertedCardDetection field from structsrc/main/blackbox/blackbox.h
uint8_t invertedCardDetectionfield fromblackboxConfig_tstruct
blackbox.c
Remove invertedCardDetection initializationsrc/main/blackbox/blackbox.c
.invertedCardDetection = BLACKBOX_INVERTED_CARD_DETECTIONinitialization from
PG_RESET_TEMPLATEsettings.yaml
Remove sdcard_detect_inverted setting definitionsrc/main/fc/settings.yaml
sdcard_detect_invertedsetting definitionSettings.md
Remove sdcard_detect_inverted documentationdocs/Settings.md
sdcard_detect_inverteddocumentation sectionvariants