fix: Change None aggregation to Custom #1633
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For clarity
🦋 Changeset detectedLatest commit: f458f3d The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
✅ No critical issues found. This is a straightforward UX improvement that makes the aggregation label more intuitive for users. The change is well-scoped and includes an appropriate changeset. |
Contributor
E2E Test Results✅ All tests passed • 61 passed • 4 skipped • 766s
Tests ran across 4 shards in parallel. |
teeohhem
requested review from
a team,
brandon-pereira and
wrn14897
and removed request for
a team and
brandon-pereira
teeohhem
changed the title
pulpdrew
approved these changes
Feb 2, 2026
wrn14897
approved these changes
Feb 2, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Justification: "None" is confusing to customers. Custom reflects the ability for users to use their own aggregation in the where clause.