Disable unimplemented virtual scrolling mode #385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
severo
added a commit
that referenced
this pull request
Jan 13, 2026
* Revert "Disable unimplemented virtual scrolling mode (#385)" This reverts commit b24b3b2. * Implement virtual scroll * virtualScrollTop is undefined initially + increase coarse threshold + update scroll states for local scroll * handle better pending programmatic scroll * add explanation about the coarse scrolling threshold * comments * [refactor] one scale object for both directions * adapt locally with scrollDelta * [refactor] use a reducer for the scroll state * [refactor] move dimensions to scale state * [refactor] handle part of the logic in the reducer * remove unneeded min threshold * [refactor] rename virtualScrollBase and virtualScrollDelta * [refactor] reorder the code for clarity * update scroll threshold (500 rows) * copilot comments * refactor * [refactor] extract derived values computation in a testable function * [refactor] move logic to virtualScroll helper and add tests * [refactor] extract logic to helper + add tests * Why not 1 peta rows?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.