⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Add handling for reformatted archives conditional on archive format version#5145

Open
letitz wants to merge 8 commits intomasterfrom
update_clusterfuzz_unzipping2
Open

Add handling for reformatted archives conditional on archive format version#5145
letitz wants to merge 8 commits intomasterfrom
update_clusterfuzz_unzipping2

Conversation

@letitz
Copy link
Collaborator

@letitz letitz commented Jan 27, 2026

Opening on behalf of @mverde to start reviewing early.

Copy link
Collaborator Author

@letitz letitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First round. I'm excited to see this land!

Copy link
Collaborator Author

@letitz letitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smaller comments this time around, except that we still need tests :)

@cemon721-a11y
Copy link

cemon721-a11y commented Jan 30, 2026 via email

Copy link
Collaborator Author

@letitz letitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nearly there!

Copy link

@cemon721-a11y cemon721-a11y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix! Using getattr() to handle the missing attribute looks like the right approach. This will unblock our workflow." And if I did again some mistakes the kindly please Send Simply inbox To my Gmail address.

Copy link
Collaborator Author

@letitz letitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! I apparently cannot approve my own PR, so @decoNR for review.

@letitz letitz requested a review from decoNR February 6, 2026 15:21
@decoNR
Copy link
Contributor

decoNR commented Feb 6, 2026

It seems that lint is failing. Please fix it, thanks!

@mverde mverde marked this pull request as ready for review February 6, 2026 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants