refactor: centralize notification removal logic and re-enable mark as done #2518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… done - Add shouldRemoveNotificationsFromState helper to centralize the logic for determining if notifications should be removed or kept in-place - Re-enable "Mark as done" button for unread notifications regardless of fetchReadNotifications setting (it still works, just appears as "read" after refresh due to GitHub API limitation) - Simplify useNotifications hook by using removeNotificationsForAccount consistently for both settings - Update tests to reflect new behavior
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #2488 that addresses refinements:
shouldRemoveNotificationsFromStatehelper to centralize the logic for determining if notifications should be removed or kept in-placefetchReadNotificationssetting (it still works, just appears as "read" after refresh due to GitHub API limitation)useNotificationshook by usingremoveNotificationsForAccountconsistently for both settingsNotificationRow.tsx,RepositoryNotifications.tsx, anduseNotifications.tsKey Changes
remove.tsshouldRemoveNotificationsFromState()helperNotificationRow.tsxRepositoryNotifications.tsxuseNotifications.tsTest plan
npm test)npm run build)fetchReadNotificationsenabled