feat(browser): Add CDN bundle for tracing.logs.metrics
#18784
+73
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| }); | ||
| }); | ||
|
|
||
|
|
There was a problem hiding this comment.
Feature PR lacks integration or E2E test
Low Severity · BugBot Rules
This is a feat PR that only includes a unit test. The review rules specify: "When reviewing a feat PR, check if the PR includes at least one integration or E2E test. If neither of the two are present, add a comment, recommending to add one." No integration or E2E test exists for the new bundle.tracing.logs.metrics bundle in browser-integration-tests or elsewhere. Adding an integration test to verify the CDN bundle loads and functions correctly in a real browser environment would improve confidence in the feature.
Contributor
size-limit report 📦
|
Lms24
reviewed
Jan 13, 2026
Member
Lms24
left a comment
Lms24
left a comment
There was a problem hiding this comment.
Nice! The bundle code looks good to me. Before we merge this, let's make sure we also adjust our browser-integration-tests to test against the newly created bundle.
- We need to tell the test setup about the bundle here.
- I think we also need some adjustments in package.json and possibly in CI.
- We should also ensure that metrics integration tests run on the newly added bundle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #18782
ref #16314
Note that metrics were bundled into the base config and will be moved into this bundle starting with v11 (ref #18583)